SHA256
Cleanup Fix Custom FPS Render Timing Marker Comments
This commit is contained in:
1 parent
9e3941e3b5
commit
7c6210d2c4
3 files changed
-14
No files matched your search
@@ -102,14 +102,12 @@ public class AdvancedConfig
|
|||||||
/// </summary>
|
/// </summary>
|
||||||
public bool HighResBloomCorrection { get; set; } = false;
|
public bool HighResBloomCorrection { get; set; } = false;
|
||||||
|
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG START] ===
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// When true, fixes in-game and render bugs during SetFramerate events (where objects disappear on the first frame
|
/// When true, fixes in-game and render bugs during SetFramerate events (where objects disappear on the first frame
|
||||||
/// or parallax/tiles lag behind) by deferring manual camera rendering to the end of the frame after all LateUpdates.
|
/// or parallax/tiles lag behind) by deferring manual camera rendering to the end of the frame after all LateUpdates.
|
||||||
/// Default true.
|
/// Default true.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public bool FixCustomFrameRate { get; set; } = true;
|
public bool FixCustomFrameRate { get; set; } = true;
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG END] ===
|
|
||||||
|
|
||||||
/// <summary>File extension of the default output file name, without the dot (e.g. "mkv", "mp4"); selects the container.</summary>
|
/// <summary>File extension of the default output file name, without the dot (e.g. "mkv", "mp4"); selects the container.</summary>
|
||||||
public string FileExtension { get; set; } = "mkv";
|
public string FileExtension { get; set; } = "mkv";
|
||||||
@@ -137,9 +135,7 @@ public class AdvancedConfig
|
|||||||
ProcessAudio = source.ProcessAudio;
|
ProcessAudio = source.ProcessAudio;
|
||||||
NonTile = source.NonTile;
|
NonTile = source.NonTile;
|
||||||
HighResBloomCorrection = source.HighResBloomCorrection;
|
HighResBloomCorrection = source.HighResBloomCorrection;
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG START] ===
|
|
||||||
FixCustomFrameRate = source.FixCustomFrameRate;
|
FixCustomFrameRate = source.FixCustomFrameRate;
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG END] ===
|
|
||||||
FileExtension = source.FileExtension;
|
FileExtension = source.FileExtension;
|
||||||
firePlanetColor = source.firePlanetColor;
|
firePlanetColor = source.firePlanetColor;
|
||||||
icePlanetColor = source.icePlanetColor;
|
icePlanetColor = source.icePlanetColor;
|
||||||
|
|||||||
@@ -6,7 +6,6 @@ using UnityEngine;
|
|||||||
|
|
||||||
namespace ADOFAIRenderer.Patch.Game;
|
namespace ADOFAIRenderer.Patch.Game;
|
||||||
|
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG START] ===
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Fixes the in-game and render bug where objects (floors, decorations, planets) disappear on the first frame of
|
/// Fixes the in-game and render bug where objects (floors, decorations, planets) disappear on the first frame of
|
||||||
/// a SetFramerate event (due to camera Z=0 near clip culling) and where parallax/tiles lag behind on subsequent frames.
|
/// a SetFramerate event (due to camera Z=0 near clip culling) and where parallax/tiles lag behind on subsequent frames.
|
||||||
@@ -112,4 +111,3 @@ internal class CustomFrameRateDeferredRunner : MonoBehaviour
|
|||||||
CustomFrameRateDeferPatch.ExecuteDeferredRender();
|
CustomFrameRateDeferPatch.ExecuteDeferredRender();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG END] ===
|
|
||||||
@@ -140,9 +140,7 @@ internal static class RenderConfigWindow
|
|||||||
private static O5Toggle? _processAudioToggle;
|
private static O5Toggle? _processAudioToggle;
|
||||||
private static O5Toggle? _nonTileToggle;
|
private static O5Toggle? _nonTileToggle;
|
||||||
private static O5Toggle? _highResBloomCorrectionToggle;
|
private static O5Toggle? _highResBloomCorrectionToggle;
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG START] ===
|
|
||||||
private static O5Toggle? _fixCustomFrameRateToggle;
|
private static O5Toggle? _fixCustomFrameRateToggle;
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG END] ===
|
|
||||||
|
|
||||||
// Planet color overrides: the toggle enables the override, the picker holds the color. A disabled toggle stores
|
// Planet color overrides: the toggle enables the override, the picker holds the color. A disabled toggle stores
|
||||||
// null in AdvancedConfig (no override is applied by PersistencePatch) and blocks the picker.
|
// null in AdvancedConfig (no override is applied by PersistencePatch) and blocks the picker.
|
||||||
@@ -794,7 +792,6 @@ internal static class RenderConfigWindow
|
|||||||
generateLabel: false
|
generateLabel: false
|
||||||
);
|
);
|
||||||
|
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG START] ===
|
|
||||||
// Fix SetFramerate Render Timing (AdvancedConfig.FixCustomFrameRate): defers manual camera rendering to frame end
|
// Fix SetFramerate Render Timing (AdvancedConfig.FixCustomFrameRate): defers manual camera rendering to frame end
|
||||||
_fixCustomFrameRateToggle = CreateToggleField(
|
_fixCustomFrameRateToggle = CreateToggleField(
|
||||||
ctx, CreateFieldSlot(advRight),
|
ctx, CreateFieldSlot(advRight),
|
||||||
@@ -810,7 +807,6 @@ internal static class RenderConfigWindow
|
|||||||
},
|
},
|
||||||
generateLabel: false
|
generateLabel: false
|
||||||
);
|
);
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG END] ===
|
|
||||||
|
|
||||||
// 7-1. Planet Color Settings (Optional).
|
// 7-1. Planet Color Settings (Optional).
|
||||||
// For each planet: the toggle turns the override on/off (off stores null and blocks/collapses the picker);
|
// For each planet: the toggle turns the override on/off (off stores null and blocks/collapses the picker);
|
||||||
@@ -1021,9 +1017,7 @@ internal static class RenderConfigWindow
|
|||||||
_processAudioToggle?.Set(config.AdvancedConfig.ProcessAudio, false);
|
_processAudioToggle?.Set(config.AdvancedConfig.ProcessAudio, false);
|
||||||
_nonTileToggle?.Set(config.AdvancedConfig.NonTile, false);
|
_nonTileToggle?.Set(config.AdvancedConfig.NonTile, false);
|
||||||
_highResBloomCorrectionToggle?.Set(config.AdvancedConfig.HighResBloomCorrection, false);
|
_highResBloomCorrectionToggle?.Set(config.AdvancedConfig.HighResBloomCorrection, false);
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG START] ===
|
|
||||||
_fixCustomFrameRateToggle?.Set(config.AdvancedConfig.FixCustomFrameRate, false);
|
_fixCustomFrameRateToggle?.Set(config.AdvancedConfig.FixCustomFrameRate, false);
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG END] ===
|
|
||||||
|
|
||||||
// Planet colors: toggle on when an override is stored; the picker shows the stored color or the default and is
|
// Planet colors: toggle on when an override is stored; the picker shows the stored color or the default and is
|
||||||
// blocked without an override
|
// blocked without an override
|
||||||
@@ -1206,9 +1200,7 @@ internal static class RenderConfigWindow
|
|||||||
if (_processAudioToggle != null) target.AdvancedConfig.ProcessAudio = _processAudioToggle.Value;
|
if (_processAudioToggle != null) target.AdvancedConfig.ProcessAudio = _processAudioToggle.Value;
|
||||||
if (_nonTileToggle != null) target.AdvancedConfig.NonTile = _nonTileToggle.Value;
|
if (_nonTileToggle != null) target.AdvancedConfig.NonTile = _nonTileToggle.Value;
|
||||||
if (_highResBloomCorrectionToggle != null) target.AdvancedConfig.HighResBloomCorrection = _highResBloomCorrectionToggle.Value;
|
if (_highResBloomCorrectionToggle != null) target.AdvancedConfig.HighResBloomCorrection = _highResBloomCorrectionToggle.Value;
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG START] ===
|
|
||||||
if (_fixCustomFrameRateToggle != null) target.AdvancedConfig.FixCustomFrameRate = _fixCustomFrameRateToggle.Value;
|
if (_fixCustomFrameRateToggle != null) target.AdvancedConfig.FixCustomFrameRate = _fixCustomFrameRateToggle.Value;
|
||||||
// === [MARKER: FIX_SET_FRAMERATE_BUG END] ===
|
|
||||||
|
|
||||||
// Planet Colors
|
// Planet Colors
|
||||||
target.AdvancedConfig.firePlanetColor = (_firePlanetToggle?.Value == true && _firePlanetPicker != null)
|
target.AdvancedConfig.firePlanetColor = (_firePlanetToggle?.Value == true && _firePlanetPicker != null)
|
||||||
|
|||||||
Reference in new issue
Block a user